-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13 to test matrix #295
Conversation
Now that it's released, we should test it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
+ Coverage 94.26% 95.26% +0.99%
==========================================
Files 5 5
Lines 401 401
Branches 90 90
==========================================
+ Hits 378 382 +4
Misses 14 14
+ Partials 9 5 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Re ef57f6f: I'm not sure how I feel about bumping everything at once - does |
Also: Should we add a version guard |
I decided on a full upgrade in place of trying to upgrade pandas, numpy, polars etc. incrementally, but I can do that too. |
I guess if it doesn't break anything obvious it doesn't hurt (since we also don't constrain the versions in pyproject.toml). |
Semantically, all current non-development Python versions fulfill this constraint, which makes it an empty condition (until a very brief transition time in October 2025). I've seen these constraints in practice, but I'm not convinced they are all that useful. |
I actually meant I'm happy either way, just wanted to briefly discuss the point while we're thinking about the topic. |
Now that it's released, we should test it.
This will not pass until pyarrow (and possibly others) release Python 3.13 wheels. Until then, we could look at marking integration tests as xfail for 3.13, but not sure if that's worth the effort.