Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 to test matrix #295

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add Python 3.13 to test matrix #295

merged 3 commits into from
Oct 29, 2024

Conversation

nicholasjng
Copy link
Collaborator

Now that it's released, we should test it.


This will not pass until pyarrow (and possibly others) release Python 3.13 wheels. Until then, we could look at marking integration tests as xfail for 3.13, but not sure if that's worth the effort.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (9e47e70) to head (ef57f6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   94.26%   95.26%   +0.99%     
==========================================
  Files           5        5              
  Lines         401      401              
  Branches       90       90              
==========================================
+ Hits          378      382       +4     
  Misses         14       14              
+ Partials        9        5       -4     
Flag Coverage Δ
3.10 94.76% <ø> (+0.99%) ⬆️
3.11 94.76% <ø> (+0.99%) ⬆️
3.12 94.76% <ø> (+0.99%) ⬆️
3.13 94.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdrianoKF
Copy link
Contributor

Re ef57f6f: I'm not sure how I feel about bumping everything at once - does uv lock -P pyarrow suffice to make the tests pass already?

@AdrianoKF
Copy link
Contributor

AdrianoKF commented Oct 29, 2024

Also: Should we add a version guard requires-python: ">=3.10,<3.14" to pyproject.toml, since this mirrors the versions we explicitly test against?

@nicholasjng
Copy link
Collaborator Author

nicholasjng commented Oct 29, 2024

I decided on a full upgrade in place of trying to upgrade pandas, numpy, polars etc. incrementally, but I can do that too.

@AdrianoKF
Copy link
Contributor

I decided on a full upgrade in place of trying to upgrade pandas, numpy, polars etc., but I can do that too.

I guess if it doesn't break anything obvious it doesn't hurt (since we also don't constrain the versions in pyproject.toml).

@nicholasjng
Copy link
Collaborator Author

Also: Should we add a version guard requires-python: ">=3.9,<3.14" to pyproject.toml, since this mirrors the versions we explicitly test against?

Semantically, all current non-development Python versions fulfill this constraint, which makes it an empty condition (until a very brief transition time in October 2025). I've seen these constraints in practice, but I'm not convinced they are all that useful.

@AdrianoKF
Copy link
Contributor

AdrianoKF commented Oct 29, 2024

Also: Should we add a version guard requires-python: ">=3.9,<3.14" to pyproject.toml, since this mirrors the versions we explicitly test against?

Semantically, all current non-development Python versions fulfill this constraint, which makes it an empty condition (until a very brief transition time in October 2025). I've seen these constraints in practice, but I'm not convinced they are all that useful.

I actually meant >=3.10, but your point still stands somewhat. I guess what it does is give a "proper" notice once Pie-thon 3.14 comes out since you won't be able to install the package without us at least giving it a cursory test beforehand.

I'm happy either way, just wanted to briefly discuss the point while we're thinking about the topic.

@nicholasjng nicholasjng merged commit 06134be into main Oct 29, 2024
14 checks passed
@nicholasjng nicholasjng deleted the add-py313-ci branch October 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants